Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.procstat): Correctly use systemd-unit setting for finding them #16060

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(inputs.procstat): Correctly use systemd-unit setting for finding them #16060

merged 1 commit into from
Oct 23, 2024

Conversation

BDelacour
Copy link
Contributor

Summary

While trying to use telegraf for monitoring processes through procstat, I found this bug (most probably a copy-pasta issue) : CGroups is used to filter SystemdUnits but CGroups case happens before so it is never possible to use SystemdUnits filter.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16059

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added area/procstat fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 22, 2024
@BDelacour
Copy link
Contributor Author

Thanks so much for the pull request! 🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

!signed-cla

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1
Copy link
Member

!signed-cla

DStrand1
DStrand1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@DStrand1 DStrand1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 22, 2024
@srebhan srebhan changed the title fix(inputs.procstat): typo in findBySystemdUnits fix(inputs.procstat): Correctly use systemd-unit setting for finding them Oct 23, 2024
srebhan
srebhan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @BDelacour for fixing this!

@srebhan srebhan merged commit 6c45aef into influxdata:master Oct 23, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 23, 2024
srebhan pushed a commit that referenced this pull request Oct 28, 2024
@BDelacour @srebhan
fix(inputs.procstat): Correctly use systemd-unit setting for finding …
7dbaa4e 
…them (#16060)

(cherry picked from commit 6c45aef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/procstat fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.2
Development

Successfully merging this pull request may close these issues.

[inputs.procstat] unable to filter by systemd_units with filter block
3 participants
@BDelacour @DStrand1 @srebhan